Skip to content

Conversation

@bangconghuynh
Copy link
Contributor

Bumped ndarray to 0.17.

@Icxolu
Copy link
Contributor

Icxolu commented Nov 10, 2025

Thank you! Could you also add a changelog entry please?

@bangconghuynh
Copy link
Contributor Author

Thank you! Could you also add a changelog entry please?

I have created an entry for rust-numpy v0.27.1. I hope that is okay.

Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sounds good to me 👍

@Icxolu Icxolu merged commit d7283f3 into PyO3:main Nov 10, 2025
77 checks passed
@konn
Copy link

konn commented Dec 1, 2025

Just curious, but when is this change shipped to crates.io?

@Icxolu
Copy link
Contributor

Icxolu commented Dec 1, 2025

Generally there is a release when a new PyO3 major version ships. PyO3 0.28 is loosely targeted around end of the year. But it looks like there is some interest in this getting shipped, so I can see if I get to prepare a patch release sooner.

@kylebarron
Copy link

Thank you! Could you also add a changelog entry please?

I have created an entry for rust-numpy v0.27.1. I hope that is okay.

This is a breaking change so you might need to make a breaking release of rust-numpy, right?

@Icxolu
Copy link
Contributor

Icxolu commented Dec 1, 2025

I should not be breaking, we just extended the supported range of ndarray versions.

@kylebarron
Copy link

Ah, apologies! I didn't look closely enough to see that it didn't force users to use ndarray 0.17

@Icxolu
Copy link
Contributor

Icxolu commented Dec 1, 2025

No worries

@Havunen
Copy link

Havunen commented Dec 2, 2025

We are also waiting for ndarray 0.17 support to rust-numpy to move forward with other crates

@Icxolu
Copy link
Contributor

Icxolu commented Dec 2, 2025

Done in #517, should be live now 🎉

@prehner
Copy link

prehner commented Dec 4, 2025

I'm not familiar enough with cargo's dependency resolver to be able to tell why this fails exactly, but this change did in fact break our code that depends on ndarray and numpy. The numpy dependency wants to pull ndarray 0.17 whereas our code was still on ndarray 0.16. Do you know a way to avoid numpy picking 0.17 so that we don't encounter these problems in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants