-
Notifications
You must be signed in to change notification settings - Fork 129
Bumped ndarray to 0.17. #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you! Could you also add a changelog entry please? |
I have created an entry for |
Icxolu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sounds good to me 👍
|
Just curious, but when is this change shipped to crates.io? |
|
Generally there is a release when a new PyO3 major version ships. PyO3 0.28 is loosely targeted around end of the year. But it looks like there is some interest in this getting shipped, so I can see if I get to prepare a patch release sooner. |
This is a breaking change so you might need to make a breaking release of |
|
I should not be breaking, we just extended the supported range of |
|
Ah, apologies! I didn't look closely enough to see that it didn't force users to use ndarray 0.17 |
|
No worries |
|
We are also waiting for ndarray 0.17 support to rust-numpy to move forward with other crates |
|
Done in #517, should be live now 🎉 |
|
I'm not familiar enough with cargo's dependency resolver to be able to tell why this fails exactly, but this change did in fact break our code that depends on ndarray and numpy. The numpy dependency wants to pull ndarray 0.17 whereas our code was still on ndarray 0.16. Do you know a way to avoid numpy picking 0.17 so that we don't encounter these problems in the future? |
Bumped ndarray to 0.17.